Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async tests and add note to docs #1439

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Jun 3, 2024

Description

For add_limit on async resources in some cases one additional item is produced. This is probably due to an implementation specific timing reason and cannot be prevented at the moment. This adds a small note about this in the docs and makes the tests tolerant of this.

@sh-rp sh-rp marked this pull request as ready for review June 3, 2024 11:20
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 227e3ae
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/665da6e91c625d0008a4c165
😎 Deploy Preview https://deploy-preview-1439--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rudolfix rudolfix merged commit 710651a into devel Jun 3, 2024
49 of 50 checks passed
@rudolfix rudolfix deleted the docs/fix_add_limit_tests_and_add_note_to_docs branch June 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants