Docs: Updated filesystem docs with explanations for bucket URLs #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dat-a-man
changed the title
dat-a-man
changed the title
zem360
previously approved these changes
Jun 5, 2024
zem360
reviewed
Jun 5, 2024
|
|
||
| 1. You can pass the bucket URL and glob pattern or use `config.toml`. For local filesystems, use | ||
| 3. You can pass the bucket URL and glob pattern or use `config.toml`. For local filesystems, use | ||
| `file://` or skip the schema and provide the local path in a format native for your operating system. |
There was a problem hiding this comment.
Just make this a bit more clear. I understand that for local filesystem, I have to use file:// or the code shown below would also work. Just make it a bit more clear.
There was a problem hiding this comment.
I would say you can use file:// as follows:
- code example
or
Define it as follows:
[sources.filesystem] # use [sources.readers.credentials] for the "readers" source
bucket_url='~\Documents\csv_files\'
file_glob="*"
There was a problem hiding this comment.
updated as per comments
zem360
reviewed
Jun 5, 2024
zem360
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated "verified-source/filesystem" docs for
"bucket-url"explanation.+ used fix_grammar_gpt.py