Feat/1406 bumps duckdb 0.10 #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
burnash
requested changes
May 24, 2024
| @@ -57,7 +59,7 @@ class RESTClient: | |||
| Args: | |||
| base_url (str): The base URL of the API to make requests to. | |||
| headers (Optional[Dict[str, str]]): Default headers to include in all requests. | |||
| auth (Optional[AuthConfigBase]): Authentication configuration for all requests. | |||
| auth (Optional[AuthBase]): Authentication configuration for all requests. | |||
There was a problem hiding this comment.
Will it work with out existing authenticators from dlt.sources.helpers.rest_client.auth which derive from AuthConfigBase? E.g., from our example code:
from dlt.sources.helpers.rest_client import RESTClient
from dlt.sources.helpers.rest_client.auth import BearerTokenAuth
client = RESTClient(
base_url="https://api.example.com",
auth=BearerTokenAuth(token="your_access_token_here") # type: ignore
)
for page in client.paginate("/protected/resource"):
print(page)Shouldn't it be a union of AuthConfigBase and AuthBase instead?
rudolfix
force-pushed
the
feat/1406-bumps-duckdb-0.10
branch
from
d3fd1ed
to
6306270
Compare
rudolfix
force-pushed
the
feat/1406-bumps-duckdb-0.10
branch
from
6306270
to
f1740aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description