Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 15 and a bit of cleanup #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

paulmelnikow
Copy link

Thanks for this useful library! I'm looking forward to using it in my project.

It's in good shape for React 15, which is great. 👍

I made a couple changes to the dependencies, kept out some extraneous files, and removed indirection through the index file.

@paulmelnikow
Copy link
Author

I may take this in a different direction. To improve encapsulation, I'm moving responsibility for the child's flex style from the parent component to the child component. In my use case the data injected into the component determines the layout, and since the child contains the rendering logic it's the natural place to put the style logic as well.

If the parent wants to affect the style, it should do so using props. The previous behavior can be accomplished easily enough with a wrapper component.

I'm experimenting with a computeStyleFromProps function injected as a parameter when the HOC is applied. Though, I'm not convinced this is flexible enough.

Are you still interested in this project? Might you be interested in collaborating on these changes? @dlmanning

@paulmelnikow
Copy link
Author

Eh, here's what I've got: https://github.com/paulmelnikow/react-flexbox-svg

@dlmanning
Copy link
Owner

@paulmelnikow : Yes! I haven't used this module in a while, but it was a labor of love when I wrote it. I'll look over what you've done this weekend.

Thanks for your interest!

@paulmelnikow
Copy link
Author

Awesome. Curious your thoughts! I wouldn't have attempted this if I hadn't found your work.

There are a couple parts that I feel could be made clearer with your help. I couldn't understand the flow of control between FlexContext and FlexBox (which I called Layoutable).

@paulmelnikow
Copy link
Author

Hi there! I'd love to drive this forward. Would you be interested in transferring the react-flexbox-svg package over to me so I can publish my updates?

I'm paulmelnikow on npmjs.

@paulmelnikow
Copy link
Author

@dlmanning Hi! I thought I'd reach out and ask about this. Would you be up for adding me on npmjs so I can publish my updates under the original name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants