Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 24686: SumType stopped working with unmatched DeducedParame… #9031

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Jul 26, 2024

…terType template

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 26, 2024

Thanks for your pull request, @ljmf00!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9031"

@ljmf00
Copy link
Member Author

ljmf00 commented Jul 26, 2024

This should probably go to stable CC @JohanEngelen @RazvanN7 @dkorpel

@ljmf00 ljmf00 added the Industry PRs important / required by industry members label Jul 26, 2024
@ljmf00
Copy link
Member Author

ljmf00 commented Jul 26, 2024

I took the freedom to create Industry label. This is blocking Weka on upgrading to the latest language version.

@ljmf00
Copy link
Member Author

ljmf00 commented Jul 26, 2024

Buildkite error seems unrelated?

@thewilsonator
Copy link
Contributor

please retitle the commit message : "Fix issue 24686:...". also please target stable

@ljmf00
Copy link
Member Author

ljmf00 commented Jul 27, 2024

please retitle the commit message : "Fix issue 24686:...". also please target stable

The commit message is like that. Did I miss something? I thought that was for the bot to grab.

@thewilsonator
Copy link
Contributor

thewilsonator commented Jul 27, 2024

Gah, sorry. `"Fix Bugzilla issue 24686:...".

std/traits.d Show resolved Hide resolved
@ljmf00-wekaio
Copy link

Gah, sorry. `"Fix Bugzilla issue 24686:...".

Got it, I certainly didn't contribute for a while, I didn't know about this change. Thanks!

@thewilsonator
Copy link
Contributor

Got it, I certainly didn't contribute for a while, I didn't know about this change. Thanks!

Well the bot's message does say that, but I didn't notice it the first few times. I only really look for the "⚠️⚠️⚠️ Warnings ⚠️⚠️", and don't read the actual content :)

@JohanEngelen JohanEngelen changed the base branch from master to stable August 3, 2024 09:55
@JohanEngelen
Copy link
Contributor

I rebased and retargeted this PR onto stable

JohanEngelen added a commit to ldc-developers/phobos that referenced this pull request Aug 3, 2024
@JohanEngelen
Copy link
Contributor

Again an unrelated CI failure... please merge this.

@pbackus pbackus merged commit 61923d9 into dlang:stable Aug 3, 2024
10 checks passed
@ljmf00
Copy link
Member Author

ljmf00 commented Aug 5, 2024

I rebased and retargeted this PR onto stable

Thanks. Sorry, I'm not used to go to my personal github that often. I wish I could merge it to keep track of things more often. Need to change my workflow a bit to be aware of these kind of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Industry PRs important / required by industry members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants