-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 24686: SumType stopped working with unmatched DeducedParame… #9031
Conversation
Thanks for your pull request, @ljmf00! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
This should probably go to stable CC @JohanEngelen @RazvanN7 @dkorpel |
I took the freedom to create |
Buildkite error seems unrelated? |
please retitle the commit message : "Fix issue 24686:...". also please target stable |
The commit message is like that. Did I miss something? I thought that was for the bot to grab. |
Gah, sorry. `"Fix Bugzilla issue 24686:...". |
Got it, I certainly didn't contribute for a while, I didn't know about this change. Thanks! |
Well the bot's message does say that, but I didn't notice it the first few times. I only really look for the " |
I rebased and retargeted this PR onto stable |
Again an unrelated CI failure... please merge this. |
Thanks. Sorry, I'm not used to go to my personal github that often. I wish I could merge it to keep track of things more often. Need to change my workflow a bit to be aware of these kind of things. |
…terType template