-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing log function #8846
Add missing log function #8846
Conversation
Error was missing from the documentation here.
Thanks for your pull request and interest in making D better, @HuskyNator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8846" |
@@ -54,6 +54,7 @@ $(UL | |||
$(LI `trace`) | |||
$(LI `info`) | |||
$(LI `warning`) | |||
#(LI `error`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuskyNator the syntax for DDoc macros is $(MACRO_NAME ARGS)
, see: https://dlang.org/spec/ddoc#macros
#(LI `error`) | |
$(LI `error`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewilsonator please check the doc tester before merging:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a PR to fix this: #8848
Error was missing from the documentation here.