Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "GHA: Work around a $p:bug in DMD's d_do_test.d" #8835

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Oct 30, 2023

This reverts commit 4f6de84, as DMD master has been fixed (dlang/dmd#15745).

This reverts commit 4f6de84, as DMD
master has been fixed.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8835"

@kinke
Copy link
Contributor Author

kinke commented Oct 30, 2023

The unrelated FreeBSD job failure is due to this: cross-platform-actions/action#64

@ibuclaw ibuclaw merged commit 9353013 into dlang:master Oct 30, 2023
14 checks passed
@kinke kinke deleted the gha_rm_workaround branch October 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants