-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placate a bunch of Allman style violation for #8805 #8817
base: master
Are you sure you want to change the base?
Conversation
I don't necessarily agree with all of these but they show up as conflict for the other PR. This is a subset, I'll do the other ones later.
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8817" |
() @trusted | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifically I don't like this type of change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this definitely looks more correct for allman style, would not remove this from D-Scanner but possibly add some kind of config for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great, thanks!
@@ -1208,7 +1209,8 @@ if (!(is(S : T) && | |||
*/ | |||
private template isSwitchable(E) | |||
{ | |||
enum bool isSwitchable = is(typeof({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I really don't like this type of change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this looks like a bug in D-Scanner
Can we fix Dscanner instead? |
any update on this? |
ah none yet, I forgot about this PR |
ping |
how about stop using it, even. Enforce trivial matters of style with a formatter, not a linter. |
I don't necessarily agree with all of these but they show up as conflict for the other PR.
This is a subset, I'll do the other ones later.