Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by dscanner #80

Merged
merged 5 commits into from
Jun 11, 2020
Merged

Fix issues reported by dscanner #80

merged 5 commits into from
Jun 11, 2020

Conversation

dgellow
Copy link
Contributor

@dgellow dgellow commented Apr 30, 2020

No description provided.

@@ -96,7 +103,7 @@ private:
parser.fileName = "drepl";
parser.setTokens(tokens);
parser.allocator = &allocator;
parser.messageDg = delegate(string file, size_t ln, size_t col, string msg, bool isErr) {
parser.messageDg = delegate(string file, size_t ln, size_t col, string msg, bool isErr) { // @suppress(dscanner.suspicious.unused_parameter)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suppress is still a work in progress in DScanner, see dlang-community/D-Scanner#799

@dgellow
Copy link
Contributor Author

dgellow commented Apr 30, 2020

Travis build is green with linter enabled :)
I can squash the commits if that matters.

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wilzbach wilzbach merged commit ba327ce into dlang-community:master Jun 11, 2020
@dgellow dgellow deleted the fix-lint-issues branch June 19, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants