Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist Listing GET API added #292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abinabraham
Copy link

Wishlist Listing GET API added

Changes are: API URLs, views, and serializers

The remaining API related to the wishlist is in progress. Will push one by one.

@maerteijn
Copy link
Member

Hi @abinabraham thanks for contributing!

Two things before any in-depth reviews:

  • It's a good plan to add the remaining API in separate PR's one by one! 👍
  • Make sure you use the IsOwner permission for your Wishlist view
  • And last but not least: Add some tests 😄

@abinabraham
Copy link
Author

Thank you for the comment @maerteijn
Ok, I will add the test case and permissions.

@specialunderwear
Copy link
Member

@abinabraham it would be great if you could make the changes @maerteijn asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants