Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Django 5.0 and 5.1 #429

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 20, 2024

Description

Fixes #428 by adding the optional parameter exlude_parameters to the VersionedChangeList.get_queryset method. IF provided it will be passed to the super().get_queryset method, if not, it will be omitted (to work with Django 4.2).

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review October 20, 2024 15:56
@fsbraun fsbraun changed the title fix: Update get_queryset signature for Django 5+ feat: add support for Django 5.0 and 5.1 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 5 redefined get_queryset in ChangeList
1 participant