Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create missing __init__.py in management folder #366

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 3, 2024

Description

Django does not recognize djangocms_versioning's management command create_versions which creates missing version objects for versioned objects, e.g., after adding djangocms_versioning to project at a later stage.

It might be a candidate to support fixing django-cms/django-cms#7732

Update: It does not solve django-cms/django-cms#7732

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08c48a5) 90.88% compared to head (a1c975c) 90.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          72       72           
  Lines        2546     2546           
  Branches      361      361           
=======================================
  Hits         2314     2314           
  Misses        168      168           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksweb marksweb merged commit ecac82f into master Jan 3, 2024
87 checks passed
@marksweb marksweb deleted the fix/enable_management_command branch January 3, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants