Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No unlock button for published content, edit preview button for locked versions #365

Closed
wants to merge 4 commits into from

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 29, 2023

Description

This PR resolves a problem where the unlock button on a published version (where unlocking does not make sense).

It also adds a preview button to a locked version in the version change list.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (f90c5b2) to head (7fb4aa0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          72       72           
  Lines        2546     2546           
  Branches      361      361           
=======================================
  Hits         2314     2314           
  Misses        168      168           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from jrief December 29, 2023 19:20
@fsbraun fsbraun requested a review from marksweb January 15, 2024 15:40
@fsbraun fsbraun closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant