Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #363: Better UX in versioning listview #364

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

jrief
Copy link
Contributor

@jrief jrief commented Dec 29, 2023

Description

Fixes #363

Allow max two checked checkboxes when comparing versions.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

This pull request is for review and testing. I actually don't know how to add a unit test since it's client functionality only.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.89%. Comparing base (f90c5b2) to head (5ef01fc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   90.88%   90.89%           
=======================================
  Files          72       72           
  Lines        2546     2548    +2     
  Branches      361      361           
=======================================
+ Hits         2314     2316    +2     
  Misses        168      168           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Dec 29, 2023

Great idea! I am going to test the UX.

One thought comes to my mind ahead of time: There might be other bulk actions in the future which might require more than 2 versions selected. To make this PR future-proof, would it be possible to check if the option value="compare_versions" is the only one?

@jrief jrief force-pushed the issue-363-better-ux-listview branch from 6ca5b35 to c8879b2 Compare December 29, 2023 14:15
@jrief jrief merged commit 93a3e52 into django-cms:master Mar 5, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better UX: Allow max two checked checkboxes when comparing versions
2 participants