fix: Preview link language #357
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 90.86% 90.95% +0.08%
==========================================
Files 72 72
Lines 2530 2533 +3
Branches 356 356
==========================================
+ Hits 2299 2304 +5
+ Misses 170 168 -2
Partials 61 61
☔ View full report in Codecov by Sentry. |
fsbraun
force-pushed
the
fix/previewlink-language
branch
from
deca3b0
to
4eab4e5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -26,6 +26,13 @@ | |||
| emit_content_change = None | |||
|
|
|||
|
|
|||
| def is_editable(content_obj, request): | |||
| """Check of content_obj is editable""" | |||
| from .models import Version | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
| flake8 | ||
| isort | ||
| py{39.310,311}-dj{32,40,41}-sqlite | ||
| ruff |
There was a problem hiding this comment.
Where is the ruff config? I may be missing something, but can't see it.
|
Ok the change here looks good. We just need some further fixes for 3.12 so maybe that should be it's own PR to introduce that and fix the issues so we get a clean run of checks for this? |
|
@marksweb @vinitkumar The 3.12 issues reside in django-app-helper. From my side we can merge this. |
|
Ok that's fair 👍 |
Description
This PR fixes an issue with the preview links falling back to the primary language.
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.