Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add testing against django main #353

Merged
merged 7 commits into from
Jan 15, 2024
Merged

ci: Add testing against django main #353

merged 7 commits into from
Jan 15, 2024

Conversation

marksweb
Copy link
Member

This adds testing against django's main branch.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecac82f) 90.88% compared to head (9bcb377) 90.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          72       72           
  Lines        2546     2546           
  Branches      361      361           
=======================================
  Hits         2314     2314           
  Misses        168      168           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Sep 20, 2023

@marksweb You'll need to also swap installation of requirements and django main branch.

@fsbraun
Copy link
Member

fsbraun commented Sep 22, 2023

@marksweb Should we test the Django main branch with django CMS develop-4 ?

@fsbraun
Copy link
Member

fsbraun commented Nov 28, 2023

@marksweb Does it make sense to run the py3.12 against develop-4 for the time being?

@marksweb
Copy link
Member Author

@fsbraun not if support might take a while.

@fsbraun
Copy link
Member

fsbraun commented Nov 28, 2023

I think it's there.

@fsbraun
Copy link
Member

fsbraun commented Dec 29, 2023

@marksweb I added the following lines to the three test files that use assertQuerySetEqual just after the imports:

if not hasattr(CMSTestCase, "assertQuerySetEqual"):
    # Django < 4.2
    CMSTestCase.assertQuerySetEqual = CMSTestCase.assertQuerysetEqual

Might be easier to remove later...

@marksweb marksweb merged commit 4ed03c9 into master Jan 15, 2024
111 checks passed
@marksweb marksweb deleted the test/django-main branch January 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants