Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prepare release 3.1.0 #65

Merged
merged 12 commits into from
Dec 6, 2023
Merged

ci: Prepare release 3.1.0 #65

merged 12 commits into from
Dec 6, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 6, 2023

Description

This PR bumps the version and updates the changelog.

What's Changed

New Contributors

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publishing flows need updating, but after that I've setup test & production pypi for trusted publishing

uses: pypa/gh-action-pypi-publish@master
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the trusted publisher workflow rather than the old token based one;
https://github.com/django-cms/djangocms-snippet/blob/master/.github/workflows/publish-to-live-pypi.yml

uses: pypa/gh-action-pypi-publish@master
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the trusted publisher workflow rather than the old token based one;
https://github.com/django-cms/djangocms-snippet/blob/master/.github/workflows/publish-to-test-pypi.yml

@fsbraun
Copy link
Member Author

fsbraun commented Dec 6, 2023

@marksweb I've updated the flows accordingly. Essentially, the login info can go.

@marksweb
Copy link
Member

marksweb commented Dec 6, 2023

@marksweb I've updated the flows accordingly. Essentially, the login info can go.

It's a bit more than that.

runs-on: ubuntu-latest
environment:
name: pypi
url: https://pypi.org/p/djangocms-snippet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to match what the pypi project is (or will be when creating these for new projects)

name: Build and publish Python 🐍 distributions 📦 to pypi
runs-on: ubuntu-latest
environment:
name: pypi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name also needs to match what the publisher has defined, but on the whole I just call it pypi

@fsbraun
Copy link
Member Author

fsbraun commented Dec 6, 2023

Right, snippet != style. Sorry.

@fsbraun fsbraun merged commit 5177ff9 into master Dec 6, 2023
9 checks passed
@marksweb marksweb deleted the ci/prepare-3.1.0-release branch December 7, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants