fix: wizard creation error #245
Conversation
| def get_success_url(self, obj, **kwargs): | ||
| return obj.get_admin_change_url() | ||
|
|
There was a problem hiding this comment.
The Alias situation is different. I'd prefer it to go to the edit endpoint of Alias. But that might be for a different PR. What do you think, @joshyu ?
There was a problem hiding this comment.
@fsbraun,
I tested this feature by installing this PR to djangocms-quickstart locally and creating new alias from wizard button, and it seems that it's working correctly.
I don't know what do you mean here go to the edit endpoint of Alias.
There was a problem hiding this comment.
If you create a page with the wizard, you end up in the edit mode for that page. I would expect the same to happen for the alias: end in edit mode (where you can add plugins) and not in the "settings", i.e. the aliases admin. That would imply a different UX. What do you think? Could this be a topic for a different PR?
for more information, see https://pre-commit.ci
|
PS: I added a test update to run with future Django versions. |
Description
Fix #244 mentioned
get_absolute_urlmissing error while creating new alias and alias category from wizard buttonI also manually cherry-pick the search features that exists in
branch 4.0.1.xbut not inmasterbranch.Thus, we don't need to care about branch 4.0.1.x now.
Related resources
Checklist