Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Fix email_notifications migration in order to properly set content types for form (advanced) #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix email_notifications migration in order to properly set content types for form (advanced) #169

wants to merge 1 commit into from

Conversation

filwaitman
Copy link
Contributor

No description provided.

czpython
czpython suggested changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@czpython czpython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure a migration is the best place for this.
What do you think about creating those permissions (the ones in the migration) after migrations are run, the same way django does it? And just leave this migration blank.

@wfehr wfehr mentioned this pull request Oct 1, 2018
Open
@filwaitman
Copy link
Contributor Author

Hi @czpython!

So, this migration idea wasn't mine. I didn't create it, I just fixed it.
Anyway, I'm not sure what you mean by " the same way django does it". Can you elaborate about it?

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czpython czpython czpython requested changes

@kinkerl kinkerl Awaiting requested review from kinkerl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filwaitman @czpython