Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorm compilable queries #62

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

FrancoLiberali
Copy link

@FrancoLiberali FrancoLiberali commented Aug 1, 2023

In this pull request we add the badaas-orm module which is based on gorm and provides a compilable query system (autogenerated with badaas-cli). This module can be used both within a badaas application and independently. The rest of the badaas modules are adapted to use the orm module. Since this new module does not provide an http api, there is no e2e test. On the other hand, since the module performs queries to the database using gorm, testing it at the unit level is complicated by its dependency on the database. For these reasons, integration tests are added, where it is possible to test that the queries are correctly performed by the new module.

See after #61.
Related prs: ditrit/badaas-cli#2, ditrit/badaas-example#9

@FrancoLiberali FrancoLiberali force-pushed the feature/gorm_compilable_queries_3 branch 3 times, most recently from f656b13 to 1207043 Compare August 1, 2023 15:11
@FrancoLiberali FrancoLiberali mentioned this pull request Aug 2, 2023
@FrancoLiberali FrancoLiberali marked this pull request as ready for review August 2, 2023 12:56
@FrancoLiberali FrancoLiberali force-pushed the feature/gorm_compilable_queries_3 branch 2 times, most recently from 6347990 to fc7467b Compare August 7, 2023 10:06
@FrancoLiberali FrancoLiberali force-pushed the feature/gorm_compilable_queries_3 branch from fc7467b to 3aafac3 Compare August 11, 2023 07:45
@FrancoLiberali FrancoLiberali force-pushed the feature/gorm_compilable_queries_3 branch from 3aafac3 to a9c3ead Compare August 23, 2023 12:58
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

83.6% 83.6% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant