Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify handling of postgres env vars #4

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Simplify handling of postgres env vars #4

merged 3 commits into from
Jul 20, 2024

Conversation

raphaellaude
Copy link
Collaborator

@raphaellaude raphaellaude commented Jul 20, 2024 •
edited
Loading

Description

  • Just set all postgres env vars as secrets individually. It's crude / duplicative but more fullproof, plus matches the .env file layout.
  • As such, in settings we can make all of the env vars required, which simplifies the control flow across the app

Reviewers

Checklist

  • Added/Updated related documentation (if applicable).
  • Added/Updated related unit tests (if applicable).

Screenshots (if applicable):

@raphaellaude raphaellaude self-assigned this Jul 20, 2024
@raphaellaude raphaellaude merged commit 938d9cd into main Jul 20, 2024
1 check passed
@raphaellaude raphaellaude deleted the handle-missing-env-vars-2 branch July 20, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bailliekova bailliekova bailliekova approved these changes

Assignees

@raphaellaude raphaellaude

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaellaude @bailliekova