Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor examples dir #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexanderjophus
Copy link
Contributor

@alexanderjophus alexanderjophus commented Jan 31, 2024

Closes #8

Should be simpler and quicker to run examples dir now

  • - dx serve --examples desktop --platform desktop
  • - dx serve --examples web --platform web

@alexanderjophus alexanderjophus marked this pull request as ready for review January 31, 2024 20:27
@marc2332 marc2332 self-requested a review February 9, 2024 11:54
@alexanderjophus
Copy link
Contributor Author

One thing to note: I don't think I got css working on the demo web view.

@marc2332
Copy link
Member

marc2332 commented Mar 28, 2024

Hey @alexanderjophus Sorry for literally taking so long, this is my fault. I just merged support for 0.5, could you maybe resolve the conflicts? I think this PR is really needed. If you are busy or whatever let me know and I can finish this 😄

Thanks, and sorry again for the unjustifiable delay 🙏

@alexanderjophus
Copy link
Contributor Author

Hey @alexanderjophus Sorry for literally taking so long, this is my default. I just merged support for 0.5, could you maybe resolve the conflicts? I think this PR is really needed. If you are busy or whatever let me know and I can finish this 😄

Thanks, and sorry again for the unjustifiable delay 🙏

Marc! Honestly.

It's no worries ;) I'll have a look this weekend (been meaning to look at the 0.5 release)

@marc2332
Copy link
Member

Thanks ❤️

@marc2332 marc2332 self-assigned this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify running examples
2 participants