Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SymmetricEigenScalar usable but not implementable #1448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nalgebra-lapack/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ pub use self::qr::QR;
pub use self::qz::QZ;
pub use self::schur::Schur;
pub use self::svd::SVD;
pub use self::symmetric_eigen::SymmetricEigen;
pub use self::symmetric_eigen::{SymmetricEigen, SymmetricEigenScalar};

trait ComplexHelper {
type RealPart;
Expand Down
6 changes: 5 additions & 1 deletion nalgebra-lapack/src/symmetric_eigen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,18 @@ where
}
}

pub trait Sealed {}
impl Sealed for f32 {}
impl Sealed for f64 {}

/*
*
* Lapack functions dispatch.
*
*/
/// Trait implemented by scalars for which Lapack implements the eigendecomposition of symmetric
/// real matrices.
pub trait SymmetricEigenScalar: Scalar {
pub trait SymmetricEigenScalar: Scalar + Sealed {
#[allow(missing_docs)]
fn xsyev(
jobz: u8,
Expand Down