Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof of concept for mul_tr #1387

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

proof of concept for mul_tr #1387

wants to merge 11 commits into from

Commits on Apr 22, 2024

  1. Fixed a (presumed) typo in documentation in matrix_view.rs

    Fixed a (presumed) typo in documentation in matrix_view.rs.
    
    Previously it says fixed_view and fixed_slice returns a matrix with `(R::dim(), CView::dim())` consecutive components. I just changed R to RView, because presumably this is a typo.
    fangs124 authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    119d691 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update matrix_view.rs documentation

    Fixed a (presumed) typo in documentation in matrix_view.rs.
    
    Previously it says fixed_view and fixed_slice returns a matrix with `(RView, CView)` consecutive components. As per-input, and after re-reading the documentation and source code. Seems like RView and CView should be used instead of RView::dim() and CViem::dim().
    fangs124 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b7a2ae2 View commit details
    Browse the repository at this point in the history
  2. Fixed spacing in documentation in matrix_view.rs

    Fixed spacing in documentation.
    fangs124 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    48d7b17 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. added mul_tr to ops.rs

    added mut_tr and the corresponding hidden yy_mul_to_uninit function.
    fangs124 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a56c215 View commit details
    Browse the repository at this point in the history
  2. added test for mul_tr in matrix.rs

    added a test for mul_tr to verify that we get m.mul_tr(v) is m*v.transpose(). also changed the name of the previous test for tr_mul to clarify which side of the multiplication is being transposed.
    fangs124 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    83d20d3 View commit details
    Browse the repository at this point in the history
  3. Update ops.rs

    Fixed a typo.. oops.
    fangs124 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    acd2fc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95830ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ea5e0e View commit details
    Browse the repository at this point in the history
  6. removed (my own) comment

    fangs124 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    12a2046 View commit details
    Browse the repository at this point in the history
  7. fixed rustfmt

    fangs124 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e154b78 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1 from dimforge/dev

    Fixed a typo in documentation in matrix_view.rs
    fangs124 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    eb4f0f8 View commit details
    Browse the repository at this point in the history