Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glm::is_null epsilon test #1350

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Fix glm::is_null epsilon test #1350

merged 1 commit into from
Jun 23, 2024

Commits on Jan 13, 2024

  1. Fix glm::is_null epsilon test 

    The existing implementation compares each component to zero with
an epsilon; effectively `glm::all(glm::is_comp_null(v, epsilon))`.
This probably isn't the desired semantics when calling `glm::is_null`;
rather, we want to determine if the magnitude of the vector is within
`epsilon` units of zero. It's the question of circle versus square.

This behavior matches that of OpenGL Mathematics.
    @CAD97
    CAD97 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    90d2693 View commit details
    Browse the repository at this point in the history