Enable custom collider shapes #550
Conversation
|
Thanks ! the diff looks appealing ! More features less code 👍 I'd love an example and a changelog line to accompany this |
| @@ -93,6 +94,7 @@ impl<'a> fmt::Debug for ColliderView<'a> { | |||
| ColliderView::RoundConvexPolyhedron(view) => write!(f, "{:?}", view.raw), | |||
| #[cfg(feature = "dim2")] | |||
| ColliderView::RoundConvexPolygon(view) => write!(f, "{:?}", view.raw), | |||
| ColliderView::Custom(_) => write!(f, "Custom"), | |||
There was a problem hiding this comment.
if I'm understanding correctly, a good information to add here would by the number identifying the shape ?
maybe as_typed_shape() would be interesting ?
| ColliderView::Custom(_) => write!(f, "Custom"), | |
| ColliderView::Custom(shape) => write!(f, "{:?}", shape.as_typed_shape()), |
There was a problem hiding this comment.
This wouldn’t be very useful because as_typed_shape would just return TypedShape::Custom which now contains a &dyn Shape instead after dimforge/parry#216.
Unfortunately, we don’t know if the custom shape implements Debug.
We’re getting rid of the number identifying the custom shape because it’s not very useful. Instead, the user should use downcasts in their custom QueryDispatcher.
The PR allowing custom QueryDispatcher is incoming.
Co-authored-by: Thierry Berger <[email protected]>
|
Note that this isn’t really less code, I just think that it’s a better idea to move the scaling code to the On example and changelog: We can add the examples after I put out the PR for custom |
|
@Vrixyz This should be ready to merge now. |
Neo-Zhixing
force-pushed
the
custom-shape
branch
from
07e55ca
to
169dbb3
Compare
This PR proposes some changes to enable custom colliders in bevy_rapier.
Requires dimforge/parry#217
Requires dimforge/parry#216