Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify removal logic system #391

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aceeri
Copy link
Contributor

@Aceeri Aceeri commented Jul 5, 2023

Combine the 2 iterators so we don't duplicate logic of removing from the rapier context and the handle components. This also should remove a 1 frame lag between the handle getting removed.

TODO:

  • Verify this doesn't break anything, preferably by adding some tests. I don't think it will but I am slightly worried about the case where RemovedComponents might return a despawned entity, this is why I'm using the fallible command for removing the handle here.

@Vrixyz Vrixyz added D-Medium P-High arbitrary important item labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Medium P-High arbitrary important item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants