Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 | Versioning code changes #687

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

SmittieC
Copy link
Collaborator

Keeping in draft for now until the base branch is merged

Description

User Impact

Demo

Docs

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 98.05447% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/chat/bots.py 50.00% 1 Missing ⚠️
apps/events/actions.py 0.00% 1 Missing ⚠️
apps/events/views.py 0.00% 1 Missing ⚠️
apps/experiments/email.py 0.00% 1 Missing ⚠️
apps/experiments/models.py 75.00% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@@ -91,7 +91,7 @@ paths:

client = OpenAI(
api_key="your API key",
base_url=f"https://chatbots.dimagi.com/api/openai/{experiment_id}",
base_url=f"https://chatbots.dimagi.com/api/openai/{experiment_id}/default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break existing links?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There's 4 API channels, so we'll just have to tell 4 people to change the endpoint

Base automatically changed from cs/versioning_changes_in_code to main September 19, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants