Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some bilingual text error&update readme #242

Merged
merged 2 commits into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .changeset/green-foxes-rhyme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
---
'@difizen/libro-jupyter': patch
'@difizen/libro-l10n': patch
'@difizen/libro-lab': patch
'@difizen/libro-docs': patch
'@difizen/libro-code-cell': patch
'@difizen/libro-code-editor': patch
'@difizen/libro-codemirror': patch
'@difizen/libro-cofine-editor': patch
'@difizen/libro-cofine-editor-contribution': patch
'@difizen/libro-cofine-editor-core': patch
'@difizen/libro-cofine-textmate': patch
'@difizen/libro-common': patch
'@difizen/libro-core': patch
'@difizen/libro-kernel': patch
'@difizen/libro-language-client': patch
'@difizen/libro-lsp': patch
'@difizen/libro-markdown': patch
'@difizen/libro-markdown-cell': patch
'@difizen/libro-output': patch
'@difizen/libro-prompt-cell': patch
'@difizen/libro-raw-cell': patch
'@difizen/libro-rendermime': patch
'@difizen/libro-search': patch
'@difizen/libro-search-code-cell': patch
'@difizen/libro-shared-model': patch
'@difizen/libro-sql-cell': patch
'@difizen/libro-terminal': patch
'@difizen/libro-toc': patch
'@difizen/libro-virtualized': patch
'@difizen/libro-widget': patch
---

fix: fix some bilingual text error
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Language version: [English](./README.md) | [中文](./README_zh.md)

If you like this project, feel free to give us a star! 🌟🌟🌟

![image](./apps/docs/public/libro.png)
![image](./apps/docs/public/libro_en.png)

---

Expand Down Expand Up @@ -123,7 +123,7 @@ import { LibroJupyterModule } from "@difizen/libro-jupyter";

### Contact Us

💬 [Chat with us on Discord](https://discord.gg/pK8X3guD)
💬 [Chat with us on Discord](https://discord.gg/RbZ9aEKK)

🤗 [Join our DingTalk Q&A group](https://qr.dingtalk.com/action/joingroup?code=v1,k1,52f1gKWwsZBMrWjXHcQFlOJEQIbbrMO86Iulu3T3ePY=&_dt_no_comment=1&origin=11)

Expand Down
2 changes: 1 addition & 1 deletion README_zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ import { LibroJupyterModule } from "@difizen/libro-jupyter";

### 联系我们

💬 [加入 Discord](https://discord.gg/pK8X3guD)
💬 [加入 Discord](https://discord.gg/RbZ9aEKK)

🤗 [加入钉钉答疑群](https://qr.dingtalk.com/action/joingroup?code=v1,k1,52f1gKWwsZBMrWjXHcQFlOJEQIbbrMO86Iulu3T3ePY=&_dt_no_comment=1&origin=11)

Expand Down
Binary file added apps/docs/public/libro_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class KeybindInstructionsContribution
icon: KeybindInstructionsIcon,
command: KeybindInstructionsCommand.id,
order: 'l',
tooltip: l10n.t('查看快捷键'),
tooltip: () => <div>{l10n.t('查看快捷键')}</div>,
});
}

Expand Down
2 changes: 1 addition & 1 deletion packages/libro-l10n/src/lang/bundle.l10n.en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"在 Output 中查找": "Find in output",
"替换功能不能在 Output 生效": "The replacement function cannot take effect in output.",
"仅在选中 Cell 中查找": "Only find in the selected cell",
"当前文件:": "Current file: ",
"当前文件:": "Current file ",
"当前变量名已存在": "The current variable name already exists.",
"是否显示libro顶部工具栏": "Whether to show the top toolbar of libro",
"顶部工具栏": "Top toolbar",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ const CurrentFileFooterComponent = React.forwardRef(function CurrentFileFooterCo
ref: React.ForwardedRef<HTMLDivElement>,
) {
const currentFileFooterView = useInject<LibroLabCurrentFileFooterView>(ViewInstance);

const label = currentFileFooterView.navigatableView?.title.label;
return (
<div className="libro-lab-current-file-footer" ref={ref}>
<span>{`${l10n.t('当前文件:')}${
currentFileFooterView.navigatableView?.title.label || ''
}`}</span>
<span>{l10n.t('当前文件:')}</span>
{
typeof label === 'function'
? React.createElement(label) // 如果是 React.FC,调用它
: label /* 如果是 ReactNode,直接渲染 */
}
</div>
);
});
Expand Down
Loading