Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable array theory as default for array size above threshold #8468

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Re-enable array theory as default for array size above threshold #8468

wants to merge 1 commit into from

Commits on Sep 24, 2024

  1. Re-enable array theory as default for array size above threshold 

    Previously, the command line permitted setting uninterpreted functions
to "never" or "always", where "never" actually was the default. The
"automatic" mode could not be enabled in any way.

We previously attempted to do this in in diffblue#6194 (inspired by diffblue#2108, but
not picking up all its changes), but then reverted the gist of the
change in diffblue#6232 as `array-bug-6230/main.c` demonstrated lingering
issues. This PR now addresses the flaw in the array theory back-end.

We may still run into performance regressions as the threshold of 1000
bits of total size of the array object is possibly lower than where the
cost of bit-blasting exceeds the cost of constraints produced by our
current array theory implementation. Two of our existing regression
tests already demonstrate this problem, hence those now use
`--arrays-uf-never`.
    @tautschnig
    tautschnig committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dc4157e View commit details
    Browse the repository at this point in the history