Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boolean_negate for immediate simplification #8449

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

tautschnig
Copy link
Collaborator

When the operand can be a Boolean constant we can don't need to wait for simplify_exprt to clean up the avoidable not_exprt.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (2212cd6) to head (f63dfa9).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/dynamic-frames/dfcc_contract_clauses_codegen.cpp 50.00% 2 Missing ⚠️
src/goto-instrument/contracts/utils.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8449      +/-   ##
===========================================
- Coverage    78.38%   78.35%   -0.04%     
===========================================
  Files         1726     1726              
  Lines       188616   188695      +79     
  Branches     18295    18301       +6     
===========================================
- Hits        147855   147851       -4     
- Misses       40761    40844      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/util/std_expr.cpp Outdated Show resolved Hide resolved
When the operand can be a Boolean constant we can don't need to wait for
simplify_exprt to clean up the avoidable not_exprt.
@tautschnig tautschnig merged commit 5002f3b into diffblue:develop Sep 13, 2024
38 of 40 checks passed
@tautschnig tautschnig deleted the use-boolean_negate branch September 13, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants