Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of dynamic_cast from qualifierst hierarchy #8405

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

tautschnig
Copy link
Collaborator

There is no need to use virtual methods as we always know from context the exact type we are working with.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

There is no need to use virtual methods as we always know from context
the exact type we are working with.
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (b335979) to head (02ae48e).
Report is 2 commits behind head on develop.

Files Patch % Lines
jbmc/src/java_bytecode/java_qualifiers.cpp 0.00% 7 Missing ⚠️
src/ansi-c/c_qualifiers.h 92.85% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8405      +/-   ##
===========================================
+ Coverage    78.02%   78.04%   +0.02%     
===========================================
  Files         1726     1726              
  Lines       189442   189388      -54     
  Branches     18466    18466              
===========================================
+ Hits        147808   147809       +1     
+ Misses       41634    41579      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening enabled auto-merge August 7, 2024 03:19
@kroening kroening assigned tautschnig and unassigned kroening Aug 7, 2024
@kroening kroening merged commit d635850 into diffblue:develop Aug 7, 2024
38 of 40 checks passed
@tautschnig tautschnig deleted the qualifiers-no-dynamic_cast branch August 7, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants