Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add macos-14 (macOS on M1) job #8382

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

tautschnig
Copy link
Collaborator

This will exercise builds on ARM/Apple Silicon.

Fixes: #8000

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the CI label Jul 12, 2024
@tautschnig tautschnig self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (83922b2) to head (075319d).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8382      +/-   ##
===========================================
+ Coverage    78.38%   78.88%   +0.49%     
===========================================
  Files         1727     1727              
  Lines       188685   198333    +9648     
  Branches     18475    18475              
===========================================
+ Hits        147900   156453    +8553     
- Misses       40785    41880    +1095     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
tautschnig added a commit to tautschnig/cbmc that referenced this pull request Jul 15, 2024
Since version 1.0.1, CVC5 also releases a binary for macOS ARM, which
will enable CBMC CI runs on that platform (see
diffblue#8382). More recent releases of
CVC5, however, have also moved to releasing zip archives rather than
single binaries. This necessitates an overhaul of the rules to download
and install CVC5 beyond just changing the version number.
This will exercise builds on ARM/Apple Silicon.

Fixes: diffblue#8000
@tautschnig
Copy link
Collaborator Author

Once this one is merged I'd like to suggest that we drop the macos-12 job (I'll create a PR in due course).

@kroening kroening merged commit 60bb14c into diffblue:develop Oct 22, 2024
41 checks passed
@tautschnig tautschnig deleted the macos-14 branch October 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of CI testing on Apple Silicon-based devices
4 participants