Add documentation to loop contracts, __CPROVER_loop_entry #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QinyuanWu
requested review from
tautschnig,
feliperodri and
remi-delmas-3000
as code owners
tautschnig
reviewed
Jul 12, 2024
tautschnig
reviewed
Jul 12, 2024
src/goto-instrument/contracts/doc/user/contracts-history-variables.md
Outdated
Show resolved
Hide resolved
src/goto-instrument/contracts/doc/user/contracts-history-variables.md
Outdated
Show resolved
Hide resolved
src/goto-instrument/contracts/doc/user/contracts-history-variables.md
Outdated
Show resolved
Hide resolved
src/goto-instrument/contracts/doc/user/contracts-memory-predicates.md
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8377 +/- ##
===========================================
- Coverage 78.35% 78.32% -0.03%
===========================================
Files 1726 1726
Lines 188424 188506 +82
Branches 18248 18249 +1
===========================================
+ Hits 147631 147646 +15
- Misses 40793 40860 +67 ☔ View full report in Codecov by Sentry. |
qinheping
reviewed
Jul 13, 2024
|
@qinheping I added a nested loop example to the loop contract documentation to explain the havoc nature of the assigns clause. Could you please take a look to make sure everything is accurate? |
qinheping
reviewed
Jul 15, 2024
|
All suggestions have been resolved. @tautschnig @qinheping Please approve this PR if everything looks good! ^_^ |
tautschnig
approved these changes
Jul 16, 2024
…try_old add loop contract example emphasize size in bytes document assign clause for nested loop Apply suggestions from code review Co-authored-by: Michael Tautschnig <[email protected]> Apply suggestions from code review Co-authored-by: Qinheping Hu <[email protected]> add nested loop example Apply suggestions from code review Co-authored-by: Qinheping Hu <[email protected]> modify comments in nested loop example
Commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is documentation only.