Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNTHESIZER: add array-uf options #7834

Merged

Conversation

qinheping
Copy link
Collaborator

This PR allows the synthesizer to take arrays-uf-always and arrays-uf-never options and pass them into the checker when checking if a loop contracts candidate is valid.

The synthesizer should accept all backend options of CBMC. The two remaining ones are --refine-strings and --string-printable.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (f868847) 78.68% compared to head (1bf2c96) 78.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7834   +/-   ##
========================================
  Coverage    78.68%   78.68%           
========================================
  Files         1698     1698           
  Lines       194124   194128    +4     
========================================
+ Hits        152740   152759   +19     
+ Misses       41384    41369   -15     
Files Changed Coverage Δ
.../goto-synthesizer/goto_synthesizer_parse_options.h 100.00% <ø> (ø)
...oto-synthesizer/goto_synthesizer_parse_options.cpp 76.53% <80.00%> (-0.07%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinheping qinheping added the Synthesis Invariant synthesis label Jul 30, 2023
@tautschnig tautschnig merged commit 2c1a38e into diffblue:develop Aug 1, 2023
35 checks passed
@qinheping qinheping deleted the features/array_theory_in_synthesizer branch October 18, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Synthesis Invariant synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants