Fix ENABLE_ARRAY_FIELD_SENSITIVITY

[peterschrammel]

Turning off that switch would lead to compilation errors, which are now fixed.

• Each commit message has a non-empty body, explaining why the change was made.
• [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• [n/a] My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (cdea666) 78.38% compared to head (3381e08) 78.49%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7827      +/-   ##
===========================================
+ Coverage    78.38%   78.49%   +0.10%     
===========================================
  Files         1698     1698              
  Lines       194123   194123              
===========================================
+ Hits        152160   152371     +211     
+ Misses       41963    41752     -211     

Files Changed	Coverage Δ
src/goto-symex/field_sensitivity.cpp	92.69% <ø> (ø)
src/goto-symex/field_sensitivity.h	100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tautschnig]

I'd prefer to instead get rid of this #define and just leave it as a feature that can be disabled at runtime (via --max-field-sensitivity-array-size 0).

[tautschnig]

I'd prefer to instead get rid of this #define and just leave it as a feature that can be disabled at runtime (via --max-field-sensitivity-array-size 0).

We even have --no-array-field-sensitivity as I just realised (which in turn is equivalent to using --max-field-sensitivity-array-size 0). So I maintain that we just just leave it with that runtime option and get rid of the #define.