Fix big endian compatibility #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
assigned peterschrammel and tautschnig and unassigned kroening and peterschrammel
kroening
reviewed
Jul 20, 2023
| @@ -14,6 +14,39 @@ Module: Read ELF | |||
|
|
|||
| #include <istream> | |||
|
|
|||
| static void u16_to_native_endian_inplace(bool le_input, uint16_t &input) | |||
There was a problem hiding this comment.
There is no variant of these in the standard library?
There was a problem hiding this comment.
There is htons, but it's not in the standard library and it doesn't fully cover what is needed here!
kroening
approved these changes
Jul 20, 2023
We need to start searching from the least or most significant bit, the position of which depends on endianness.
Values checked for in some tests depend on endianness. Also, don't hard-code "byte_(extract|update)_little_endian and instead also accept the big-endian variant thereof.
This is pre-defined by GCC on _some_ platforms. Here, we don't want GCC pre-defined setting but instead want our own setting to test both little and big-endian settings.
We previously only supported little-endian architectures for some of the simplify_byte_update simplification rules.
Converting from integers to char arrays reveals endianness.
tautschnig
force-pushed
the
bugfixes/big-endian
branch
from
321dc37
to
bdd42d3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7811 +/- ##
===========================================
+ Coverage 78.13% 78.74% +0.61%
===========================================
Files 1698 1698
Lines 194027 194123 +96
===========================================
+ Hits 151600 152861 +1261
+ Misses 42427 41262 -1165
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit.