Initial nested page break handling. And change to unwrappable content fallback behavior.. #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fallback behavior..
🦋 Changeset detectedLatest commit: f6bdaed The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Verifying the behavior here a bit more, I found it possible to get in an infinite loop on more complicated reports. Looking into an issue with this approach when content is larger than a few pages and needs to split. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds loop to split nodes by nested page break using splitNode function.
If a node is found that has a breakable child, after performing standard pagination resolutions it will split children into two parts, putting the content after the page break in the second part, then rely on the relayout behavior to recompute as needed.
I have also changed the behavior for nodes marked as non-wrappable to fallback to wrapping if they do not fit on a page and could be wrapped.
I'm not sure if there will be other considerations here.
Looking for feedback.
Relating issues/enhancements might include:
#1037
#1676