Fix some error #1252
Merged
Fix some error #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Blackgan3
commented
Aug 10, 2023
Blackgan3
commented
- 补充errorHandler文档
- 修复局部构建模式下?resolve语法报错
- 修复局部构建模式下分包输出缺失导致构建产物无法预览问题
hiyuki
reviewed
Aug 15, 2023
packages/webpack-plugin/lib/index.js
Outdated
| }, (obj, resolverContext, callback) => { | ||
| if (isResolvingPage(obj) && !matchCondition(obj.path, this.options.partialCompile)) { | ||
| if (mpx) mpx.partialCompileFilteredPagesMap[obj.path] = true | ||
| const { resourcePath } = parseRequest(obj.path) |
hiyuki
reviewed
Aug 15, 2023
| json.subPackages = [] | ||
| } | ||
| json.subPackages.push(subPackageCfg) | ||
| if (!json.subPackages) { |
hiyuki
reviewed
Aug 15, 2023
packages/webpack-plugin/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@mpxjs/webpack-plugin", | |||
| "version": "2.8.39", | |||
| "version": "2.8.40-beta.0", | |||
hiyuki
reviewed
Aug 17, 2023
| return pagesMap[resourcePath] || currentComponentsMap[resourcePath] || mainComponentsMap[resourcePath] || currentStaticResourcesMap[resourcePath] || mainStaticResourcesMap[resourcePath] || '' | ||
| const resolveResult = pagesMap[resourcePath] || currentComponentsMap[resourcePath] || mainComponentsMap[resourcePath] || currentStaticResourcesMap[resourcePath] || mainStaticResourcesMap[resourcePath] || '' | ||
| if (!resolveResult) { | ||
| if (matchCondition(resourcePath, partialCompile)) { |
hiyuki
reviewed
Aug 17, 2023
| }, () => { | ||
| if (tarRoot && subPackagesCfg) { | ||
| if (!subPackagesCfg[tarRoot].pages.length) { | ||
| subPackagesCfg[tarRoot].pages.push(pagesCache[0]) |
hiyuki
approved these changes
Aug 18, 2023
hiyuki
reviewed
Aug 18, 2023
| } | ||
| } else { | ||
| if (!localPages.length) { | ||
| pagesCache[0] && localPages.push(pagesCache[0]) |
# Conflicts: # packages/webpack-plugin/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.