Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix portrait tree drag drop bugs #2442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix portrait tree drag drop bugs #2442

wants to merge 2 commits into from

Conversation

salianifo
Copy link
Contributor

Maybe Fixes: #2372

Added check to make sure something is selected when trying to create drag preview in the Character editor's Portrait tree. Also renamed some function arguments to avoid shadowing builtin position variable.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Oct 18, 2024
@salianifo
Copy link
Contributor Author

I'm actually wondering if instead of using get_selected() if we should check for an element under the position and get that. After testing this fix, if you have an item selected, but you drag in the empty space at the bottom, it can reorder that item, which is likely not intended, or expected by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Approved This can be added, but is not on any roadmap yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extreme zoom when trying to create new portrait
2 participants
@salianifo @Jowan-Spooner