Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(frontend): Comment on eth address derivation #2769

Merged
merged 1 commit into from
Oct 9, 2024
Merged

docs(frontend): Comment on eth address derivation #2769

merged 1 commit into from
Oct 9, 2024
+1 −0

Conversation

bitdivine
Copy link
Member

Motivation

The reason why the caller address is needed isn't clear.

Changes

  • Explain why the caller principal is important when getting the user eth address.

Tests

N/A

@bitdivine bitdivine requested a review from a team as a code owner October 9, 2024 18:39
@bitdivine bitdivine enabled auto-merge (squash) October 9, 2024 18:40
@bitdivine bitdivine changed the title doc(frontend): Comment on eth address derivation docs(frontend): Comment on eth address derivation Oct 9, 2024
peterpeterparker
peterpeterparker approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bitdivine bitdivine merged commit 51950de into main Oct 9, 2024
10 of 11 checks passed
@bitdivine bitdivine deleted the papi-slice-1 branch October 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitdivine @peterpeterparker