refactor(frontend): Extract Button that represents Done action #2765
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import Button from '$lib/components/ui/Button.svelte'; | ||
| import { i18n } from '$lib/stores/i18n.store'; | ||
| export let type: 'submit' | 'reset' | 'button' = 'submit'; |
There was a problem hiding this comment.
Is it really ever used to submit a form? If not, should we also set it as button for all use case?
There was a problem hiding this comment.
I didn't want to change the logic to be honest, just in case it is needed as submit somewhere.
But it make sense that "Done" does not submit a form.
I double checked and it is really never used in a form, you are right! Changed
AntonioVentilii-DFINITY
deleted the
refactor(frontend)/Extract-Button-that-represents-Done-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step to reduce duplication and concentrate components in one place: we extract the button the is used as "Done".
NOTE: The button is always at full width.