Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Adjust style according to Sass warnings #2753

Conversation

AntonioVentilii-DFINITY
Copy link
Collaborator

Motivation

As found by @peterpeterparker , a recent change in the button styles created Sass compiler to raise some deprecation warnings, for example:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls


11  │ ┌     &:not([disabled]) {
12  │ │         cursor: pointer;
13  │ │     }
    │ └─── nested rule
... │
16  │       border-radius: var(--button-border-radius);
    │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration

    src/frontend/src/lib/styles/global/button.scss 16:2  @import
    src/frontend/src/lib/styles/global.scss 12:9         root stylesheet

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit 5db6df6 into main Oct 9, 2024
9 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the fix(build)/Adjust-style-according-to-Sass-warnings branch October 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants