Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(frontend): shift the main content up when on larger screens [GIX-3046] #2742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntonioVentilii-DFINITY
Copy link
Collaborator

Motivation

For the new layout, the first step is to move the main content in the middle of the header when the screen is larger.

Furthermore, we remove the Alpha element and we move Hero inside <main> since we will treat what's inside it as a single component.

NOTE: the changes are just for larger screens when logged in. The rest is unchanged.

Screen.Recording.2024-10-08.at.20.02.25.mov

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner October 8, 2024 18:06
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY changed the title style(frontend): shift the main content up when on larger screens style(frontend): shift the main content up when on larger screens [GIX-3046] Oct 8, 2024
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove "Alpha" in a separed dedicated PR?

@AntonioVentilii-DFINITY
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants