Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devops): Rename test-fe-X to test_fe_X #2730

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(devops): Rename test-fe-X to test_fe_X #2730

merged 1 commit into from
Oct 8, 2024

Conversation

lmuntaner
Copy link
Contributor

Motivation

vite build was broken with:

error during build:
[commonjs--resolver] Transform failed with 32 errors:
error: The define key "import.meta.env.VITE_TEST-FE-1_ICP_LEDGER_CANISTER_ID" contains invalid identifier "VITE_TEST-FE-1_ICP_LEDGER_CANISTER_ID"
error: The define key "import.meta.env.VITE_TEST-FE-1_BACKEND_CANISTER_ID" contains invalid identifier "VITE_TEST-FE-1_BACKEND_CANISTER_ID"
error: The define key "import.meta.env.VITE_TEST-FE-1_INTERNET_IDENTITY_CANISTER_ID" contains invalid identifier "VITE_TEST-FE-1_INTERNET_IDENTITY_CANISTER_ID"
error: The define key "import.meta.env.VITE_TEST-FE-2_CKBTC_MINTER_CANISTER_ID" contains invalid identifier "VITE_TEST-FE-2_CKBTC_MINTER_CANISTER_ID"
error: The define key "import.meta.env.VITE_TEST-FE-1_CYCLES_LEDGER_CANISTER_ID" contains invalid identifier "VITE_TEST-FE-1_CYCLES_LEDGER_CANISTER_ID"
...

The - can't be present in identifiers.

Changes

  • Rename test-fe-1 and test-fe-2 to test_fe_1 and test_fe_2.

Tests

Tested locally that npm run build still works.

@lmuntaner lmuntaner marked this pull request as ready for review October 8, 2024 11:38
@lmuntaner lmuntaner requested a review from a team as a code owner October 8, 2024 11:38
@lmuntaner
Copy link
Contributor Author

@bitdivine please review

@lmuntaner lmuntaner enabled auto-merge (squash) October 8, 2024 11:40
@lmuntaner lmuntaner merged commit 1328b30 into main Oct 8, 2024
7 checks passed
@lmuntaner lmuntaner deleted the lm-fix-test-fe-1 branch October 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY AntonioVentilii-DFINITY approved these changes

@bitdivine bitdivine Awaiting requested review from bitdivine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @AntonioVentilii-DFINITY