Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(doc): make OISY name uppercase #2725

Merged
merged 4 commits into from
Oct 8, 2024
Merged

chore(doc): make OISY name uppercase #2725

merged 4 commits into from
Oct 8, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Collaborator

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY commented Oct 8, 2024 •
edited
Loading

Motivation

We change every instance of Oisy to OISY. In another moment we will decide wether to use OISY Wallet or just OISY.

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY marked this pull request as ready for review October 8, 2024 11:38
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner October 8, 2024 11:38
peterpeterparker
peterpeterparker approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit a0db34a into main Oct 8, 2024
10 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the chore(doc)/make-OISY-name-uppercase branch October 8, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii-DFINITY @peterpeterparker