feat(backend): Class to manage btc pending transactions #2598
Conversation
|
@bitdivine please review |
lmuntaner
force-pushed
the
lm-add-btc-pending-transaction-impl
branch
from
e0d35e9
to
8627aae
Compare
| pub struct BtcUserPendingTransactions { | ||
| /// Map of `user_principal` to `PendingTransactionsMap`; | ||
| pending_transactions_map: HashMap<Principal, PendingTransactionsMap>, | ||
| /// Maximum number of transactions stored per principal. |
There was a problem hiding this comment.
Unsure whether this is the actual maximum or the allowed maximum. I think it's the allowed maximum? Maybe tweaking the text would make this clear. Something like this, maybe?
| /// Maximum number of transactions stored per principal. | |
| /// Maximum number of transactions that will be stored per `(principal, address)` tuple. |
| } | ||
| } | ||
|
|
||
| /// Returns the pending transactions of a specific principal per address. |
There was a problem hiding this comment.
Can multiple users share the same Bitcoin address? Not if the Bitcoin address is derived from the principal, I guess, but maybe in future. My concern is that if one user makes a transaction, it may not appear for others sharing the same address. This is not going to happen if we commit to not sharing addresses.
There was a problem hiding this comment.
At the moment, we don't share addreses.
This would be a problem not only for sharing, but if multiple users can make transactions from the same address. Which at the moment is not supported in CFS either.
But it's something to keep in mind for the future. I'll add a comment.
| current_utxos: &[Utxo], | ||
| now_ns: u64, | ||
| ) { | ||
| if let Some(address_map) = self.pending_transactions_map.get_mut(&principal) { |
There was a problem hiding this comment.
Do I see correctly that the number of addresses per principal is unbounded?
lmuntaner
force-pushed
the
lm-add-btc-pending-transaction-impl
branch
from
216d63c
to
70e29b8
Compare
Motivation
We want to store pending btc transactions to disable users from making transactions while there is one that hasn't finished.
In this PR, I introduce the module to manage the pending transactions. It adds functionality to add, read and prune the pending transaction.
This struc will then be added to the heap, (hence that I put it inside a directory
heap_state) and used in the backend endpoints.Changes
BtcUserPendingTransactionsin moduleheap_state/btc_user_pending_tx_state.Tests