Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): use object param for scripts #2451

Merged

Conversation

AntonioVentilii-DFINITY
Copy link
Collaborator

Motivation

We remove one of the "temporary" exceptions to the new custom ES lint rule introduced by PR #2416 , and adapt the code. Specifically the one concerning scripts.

Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit a9b515d into main Sep 21, 2024
7 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the refactor(ci)/use-object-param-for-scripts branch September 21, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants