Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devops): Add cycles ledger and depositor #2375

Merged
merged 3 commits into from
Sep 17, 2024
Merged

feat(devops): Add cycles ledger and depositor #2375

merged 3 commits into from
Sep 17, 2024

Conversation

bitdivine
Copy link
Member

Motivation

Oisy will have to start paying cycles for signing. To support that in tests, we will need the cycles ledger and cycles depositor (used in test environments to add cycles to the cycle ledger).

Changes

  • Add the cycles_ledger and cycles_depositor to dfx.json.

Tests

Existing tests should suffice.

Locally, npm run deploy works.

@bitdivine bitdivine marked this pull request as ready for review September 16, 2024 15:59
@bitdivine bitdivine requested a review from a team as a code owner September 16, 2024 15:59
@bitdivine bitdivine enabled auto-merge (squash) September 16, 2024 15:59
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One question.

"cycles_depositor": {
"dependencies": ["cycles_ledger"],
"type": "custom",
"build": "scripts/build.cycles_depositor.sh",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use candid and wasm entries because the arguments need to be dynamic?

@bitdivine bitdivine merged commit a030cae into main Sep 17, 2024
9 checks passed
@bitdivine bitdivine deleted the papi branch September 17, 2024 07:26
@peterpeterparker
Copy link
Member

Please update main deploy.sh script if those need to be spinned to develop locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants