Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Remove signing apis #2369

Merged
merged 12 commits into from
Sep 16, 2024
Merged

chore(backend): Remove signing apis #2369

merged 12 commits into from
Sep 16, 2024

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Sep 16, 2024

Motivation

The backend canister signing APIs are now provided by the chain fusion signer.

Changes

  • Remove all signing and threshold signature APIs from the backend canister.
  • Remove the utilities and tests for these methods.
  • Fixes:
    • Get the SignRequest typescript data type from the signer bindings rather than the backend bindings. This was an oversight but has no consequence as the types are the same.

Not removed:

  • Anything beyond the bulk removal of methods and immediate dependencies. For example:
    • The migration methods, or if we wish to keep the migration methods, the threshold signing aspects of migration.
    • Removal of dependencies in Crates.toml that may be used only for signing.
    • I have not made a detailed scan for other small things that might be removed or simplified.
    • Any frontend simplification possible now that the backend and signer are definitely distinct.

Tests

  • Existing CI should cover the remaining functionality.
  • The chain fusion signer CI should cover the signing methods comprehensively.

@bitdivine bitdivine marked this pull request as ready for review September 16, 2024 12:52
@bitdivine bitdivine requested a review from a team as a code owner September 16, 2024 12:52
Copy link
Collaborator

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tks!

@bitdivine bitdivine merged commit 7a5cca0 into main Sep 16, 2024
21 checks passed
@bitdivine bitdivine deleted the remove-signing-apis branch September 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants